Page MenuHomePhorge
Create Task
Maniphest T342

$wgServer not updated for Hub leading to insecure forms
Closed, ResolvedPublic
Actions

Description

The filter editor on Special:AbuseFilter uses, e.g., <form action="http://www.shoutwiki.com/wiki/Special:AbuseFilter/15" method="post" id="mw-abusefilter-editing-form"> (for filter 15). It's broken as http. It works as https. There might be other forms scattered around that need to be updated, too.

Event Timeline

Saftzie created this task.Sep 6 2024, 10:37 PM
Saftzie removed a subscriber: Saftzie.
lewiscawte closed this task as Resolved.Sep 8 2024, 4:24 PM
lewiscawte claimed this task.
lewiscawte triaged this task as Normal priority.
lewiscawte added a subscriber: lewiscawte.

It's built off $wgServer - which we updated for all wikis. However, it seems not Hub, as Hub's settings file was handwritten and has a non-standard indentation, so the find/replace didn't catch it.

lewiscawte renamed this task from Update form action from http to https to $wgServer not updated for Hub leading to insecure forms.Sep 8 2024, 4:25 PM