Page MenuHomePhorge

Cleanup Piwik
Closed, ResolvedPublic

Description

The Piwik Tracking code was updated in rSHWK4001 as a quick-fix for the continued lack of any analytics what so ever.

This has resulted in many currently unused variables left lying about in the code. The following should be reviewed and removed or implemented where necessary/possible.

@jack Wrote:
  1. $protocol is now unused, drop it, and thus you can also drop the $wgRequest global declaration (line 14) 3) I would really really *really* prefer if the JS would be indented with a...

[00:10:01] <@ashley> ...single tab instead of two spaces ;-) 4) on a closer look, it appears that you can also drop $wgPiwikCustomJS (from L13 as well as extension.json) and $wgPiwikActionName (L13) and $finalActionName (L40-43)

Event Timeline

jack claimed this task.