Page MenuHomePhabricator

160x600 skyscraper ads overflows 120x600 iframe
Open, HighPublic

Description

Vector and Aurora displays a 160x600 skyscraper ad, but puts it inside a 120x600 iframe with an overflow:hidden style declaration. This makes the ad appear cropped off at the right on Vector, and overflows in to the content area on Aurora.

Event Timeline

lewiscawte triaged this task as Normal priority.Mar 13 2017, 1:42 PM

Should be fixed when rSHWK4162 is deployed.

The outermost div#column-google is now 160px wide, but some of the intermediate nested elements remain 120px.

Editing attributes on these four elements in developer view fixes the problem client side:

ins#aswift_2_expand
style = "...width:160px;..."

ins#aswift_2_anchor
style = "...width:160px;..."

#aswift_2_anchor iframe (the iframe child of #aswift_2_anchor)
width = "160"
style = "...width:160px;..."

iframe#google_ads_frame3
width = "160"

I'm not familiar enough with the server side code to pinpoint where the 120's are coming from, but I hope this helps.

lewiscawte raised the priority of this task from Normal to High.

I've got a number of fixes upstream that I've yet to pull down to ShoutWiki - I believe this might be amongst them?

lewiscawte updated the task description. (Show Details)Mar 14 2019, 12:30 AM
lewiscawte renamed this task from Vector 160x600 skyscraper ad overflows 120x600 iframe to 160x600 skyscraper ads overflows 120x600 iframe.