SkinsUmbrella
ActivePublic

Members (2)

Watchers

  • This project does not have any watchers.

Properties

Description

For everything and anything to do with ShoutWiki's skins which do not have their own component in Phabricator.

Recent Activity

Sat, Mar 25

lewiscawte added a project to T191: Issues about Vector Skin - dropdown menus are covered by right ads.: Advertising.
Sat, Mar 25, 1:19 AM · Advertising, Skins
lewiscawte lowered the priority of T191: Issues about Vector Skin - dropdown menus are covered by right ads. from "High" to "Normal".
Sat, Mar 25, 1:19 AM · Advertising, Skins

Fri, Mar 24

Utolee90 triaged T191: Issues about Vector Skin - dropdown menus are covered by right ads. as "High" priority.
Fri, Mar 24, 3:55 PM · Advertising, Skins
Utolee90 created T191: Issues about Vector Skin - dropdown menus are covered by right ads..
Fri, Mar 24, 3:54 PM · Advertising, Skins

Tue, Mar 14

lewiscawte added a project to T112: Make branding consistent: Design.
Tue, Mar 14, 2:31 AM · Design, Skins
lewiscawte added a project to T53: Investigate Metrolook ad placement: Advertising.
Tue, Mar 14, 1:23 AM · Advertising, Skins
lewiscawte added a project to T54: User menu is overlayed by ShoutWikiAds sidebar advertisement : Advertising.
Tue, Mar 14, 1:23 AM · Advertising, Skins
lewiscawte added a project to T174: Vector 160x600 skyscraper ad overflows 120x600 iframe: Advertising.
Tue, Mar 14, 1:22 AM · Advertising, Skins

Mon, Mar 13

lewiscawte added a comment to T174: Vector 160x600 skyscraper ad overflows 120x600 iframe.

Should be fixed when rSHWK4162 is deployed.

Mon, Mar 13, 1:50 PM · Advertising, Skins
lewiscawte triaged T174: Vector 160x600 skyscraper ad overflows 120x600 iframe as "Normal" priority.
Mon, Mar 13, 1:42 PM · Advertising, Skins

Feb 18 2017

MattFitzpatrick created T174: Vector 160x600 skyscraper ad overflows 120x600 iframe.
Feb 18 2017, 11:16 PM · Advertising, Skins

Jan 31 2017

SamanthaNguyen set the image for Skins to F944: fa-umbrella-blue.png.
Jan 31 2017, 3:11 AM
SamanthaNguyen set the icon for Skins to Umbrella.
Jan 31 2017, 3:11 AM

Dec 17 2016

Unknown Object (User) added a member for Skins: Unknown Object (User).
Dec 17 2016, 7:59 PM

Nov 19 2016

jack triaged T137: Tidy up CSS in Sports theme for Games skin as "Normal" priority.
Nov 19 2016, 11:54 PM · Skins, Technical Debt

Nov 14 2016

lewiscawte assigned T53: Investigate Metrolook ad placement to jack.
Nov 14 2016, 9:41 PM · Advertising, Skins

Nov 13 2016

jack edited the description of T77: High-definion logo support for certain ShoutWiki skins not utilizing Wiki.png/$wgLogo.
Nov 13 2016, 1:36 PM · Skins
jack closed T62: Consolidate the Games and Sports skins as "Resolved".

Now that Sports is a theme of Games, I've pushed that change live and undeployed Sports from Interface Messages Wiki, the only wiki where it was deployed on.

Nov 13 2016, 1:09 PM · Technical Debt, Skins

Nov 11 2016

lewiscawte triaged T54: User menu is overlayed by ShoutWikiAds sidebar advertisement as "High" priority.
Nov 11 2016, 1:03 PM · Advertising, Skins
lewiscawte triaged T53: Investigate Metrolook ad placement as "High" priority.
Nov 11 2016, 1:03 PM · Advertising, Skins
lewiscawte triaged T89: Adding Refreshed as an optional skin? as "Normal" priority.
Nov 11 2016, 1:01 PM · Skins
lewiscawte triaged T112: Make branding consistent as "Normal" priority.
Nov 11 2016, 1:01 PM · Design, Skins
lewiscawte triaged T77: High-definion logo support for certain ShoutWiki skins not utilizing Wiki.png/$wgLogo as "Low" priority.
Nov 11 2016, 12:59 PM · Skins

Aug 3 2016

lewiscawte created T112: Make branding consistent.
Aug 3 2016, 3:16 PM · Design, Skins

Jul 28 2016

jack closed T99: Make Refreshed skin compatible with ShoutWiki ads as "Resolved".

So I added (and self-merged) a new hook point, RefreshedInSidebar, to Refreshed (upstream commit), which allows us to inject 125x125px ads into the sidebar area.

Jul 28 2016, 11:37 AM · Skins
jack closed T99: Make Refreshed skin compatible with ShoutWiki ads, a subtask of T89: Adding Refreshed as an optional skin?, as "Resolved".
Jul 28 2016, 11:37 AM · Skins

Jul 25 2016

SamanthaNguyen added a parent task for T99: Make Refreshed skin compatible with ShoutWiki ads: T89: Adding Refreshed as an optional skin?.
Jul 25 2016, 10:20 PM · Skins
SamanthaNguyen added a subtask for T89: Adding Refreshed as an optional skin?: T99: Make Refreshed skin compatible with ShoutWiki ads.
Jul 25 2016, 10:20 PM · Skins
SamanthaNguyen created T99: Make Refreshed skin compatible with ShoutWiki ads.
Jul 25 2016, 10:19 PM · Skins
cook879 closed T47: Move ad settings for Metrolook from pokeru's local settings to GlobalSettings.php as "Resolved".

Fixed in rSHWK3876. Already deployed.

Jul 25 2016, 9:11 PM · Skins
cook879 closed T47: Move ad settings for Metrolook from pokeru's local settings to GlobalSettings.php, a subtask of T49: Enable Metrolook globally, as "Resolved".
Jul 25 2016, 9:10 PM · Skins

Jul 23 2016

isarra added a comment to T89: Adding Refreshed as an optional skin?.

Isn't this used on brickimedia production? It shouldn't be too likely to explode.

Jul 23 2016, 7:16 PM · Skins
jack reopened T89: Adding Refreshed as an optional skin? as "Open".

so that hopefully there's a bigger audience to test Refreshed

We're not here so you can test your code. Go break some other site.

So this was probably worded a bit badly. I'm sure that @SamanthaNguyen's intention wasn't to have unstable, potentially broken code deployed on ShoutWiki.

Jul 23 2016, 4:46 PM · Skins
SamanthaNguyen closed T89: Adding Refreshed as an optional skin? as "Invalid".

My apologies, my intention wasn't malicious (e.g trying to break any of the wikis), just a suggestion. Sorry about that.

Jul 23 2016, 9:13 AM · Skins
lewiscawte added a comment to T89: Adding Refreshed as an optional skin?.

so that hopefully there's a bigger audience to test Refreshed

Jul 23 2016, 9:07 AM · Skins
SamanthaNguyen added a project to T89: Adding Refreshed as an optional skin?: Skins.
Jul 23 2016, 8:52 AM · Skins

Jul 14 2016

jack created T77: High-definion logo support for certain ShoutWiki skins not utilizing Wiki.png/$wgLogo.
Jul 14 2016, 11:33 PM · Skins

Jul 2 2016

jack created T62: Consolidate the Games and Sports skins.
Jul 2 2016, 1:40 AM · Technical Debt, Skins
jack created T61: Remove inline CSS from the Games skin.
Jul 2 2016, 12:53 AM · Technical Debt, Skins
jack closed T60: Fix no logo Nimbus bug as "Resolved".

Upstream patch: https://gerrit.wikimedia.org/r/#/c/297114/
Local patch: {rSHWK3895}

Jul 2 2016, 12:44 AM · Skins

Jul 1 2016

jack added a comment to T60: Fix no logo Nimbus bug.
#site-logo {
	min-height: 150px;
}

fixes this bug. I'll try to commit a patch later today...

Jul 1 2016, 9:45 AM · Skins

Jun 28 2016

cook879 added a comment to T60: Fix no logo Nimbus bug.

I feel like the ideal solution to this is to deal with it via CSS, even if we just do something where we detect no image we put a blank clear one in there. We can put in as many defaults as we like, but at the end of the day that doesn't stop users deleting the images and having the bug.

Jun 28 2016, 9:44 PM · Skins

Jun 24 2016

jack added a project to T60: Fix no logo Nimbus bug: Skins.

Perhaps we should implement a default logo of some kind in the Nimbus skin itself? Right now it uses $wgLogo (i.e. Wiki.png on ShoutWiki), but some skins (such as Quartz) use that skin's custom logo (Wiki_wide.png in Quartz) and fall back to $wgLogo if there's no appropriate, skin-specific custom logo...which actually doesn't handle the "$wgLogo doesn't exist" case at all. Maybe I'm wrong and this indeed is a real code bug that we could and should handle with CSS or something. Thoughts?

Jun 24 2016, 7:48 AM · Skins

Jun 16 2016

SamanthaNguyen added a comment to T53: Investigate Metrolook ad placement.

There's a document.write in https://phabricator.wikimedia.org/diffusion/EDSN/browse/master/DismissableSiteNotice.hooks.php , what do you think?

Jun 16 2016, 10:12 PM · Advertising, Skins
jack added a comment to T53: Investigate Metrolook ad placement.

So something somewhere is calling document.write, which isn't really supported in MediaWiki anymore and that's breaking things. This results in a warning logged into the browser's JS console: "Use of 'write' is deprecated. Use jQuery or mw.loader.load instead.". This traces back to the file /resources/src/mediawiki.legacy/wikibits.js.
I was able to reproduce the broken ad behavior in Opera 37.0.2178.32 under Windows 7.

Jun 16 2016, 4:51 PM · Advertising, Skins
jack added a comment to T54: User menu is overlayed by ShoutWikiAds sidebar advertisement .
div#mw-panel-right {
	top: 120px;
}

might/should fix this, at least for anons. Tested on Opera 37.0.2178.32 under Windows 7. No idea what to do w/ logged-in users, though.

Jun 16 2016, 4:45 PM · Advertising, Skins
lewiscawte added a comment to T54: User menu is overlayed by ShoutWikiAds sidebar advertisement .

The ad needs pushing further down the page. Overlaying that user menu on top of the ad is just calling for an invalid click activity strike.

Jun 16 2016, 5:53 AM · Advertising, Skins

Jun 15 2016

MtMNC added a comment to T53: Investigate Metrolook ad placement.

Oddly enough, I've gotten several different ad placements, including the correct one. This is on Chrome 51.0.2704.84 on OS X 10.11.4 (El Capitan). Here are some examples:

Jun 15 2016, 9:08 PM · Advertising, Skins
SamanthaNguyen created T54: User menu is overlayed by ShoutWikiAds sidebar advertisement .
Jun 15 2016, 8:30 PM · Advertising, Skins
SamanthaNguyen added a comment to T53: Investigate Metrolook ad placement.

Sidebar isn't working, after a couple of refreshes here and there - Using Windows 10, Chrome v51.0.2704.84, 1366 x 768

Jun 15 2016, 8:25 PM · Advertising, Skins