Page MenuHomePhabricator

Improve ad placement in responsive Monobook
Open, Needs TriagePublic

Description

The new MediaWiki 1.32 update added an option to use responsive Monobook. However, on pages with ads enabled, the content area is very narrow, due to ads and following CSS added by ShoutWiki Ads extension:

margin-right: 125px !important
margin-left: 12.2em !important

Event Timeline

--miki-- created this task.Mar 5 2019, 11:23 AM
jack added a project: CSS.Mar 6 2019, 10:20 PM
jack added a subscriber: jack.

Nice catch, thanks!

I've submitted an experimental patch on upstream, see https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ShoutWikiAds/+/494814/ ; not yet available/live on ShoutWiki, but feel free to give it a spin if you've got a local setup (ShoutWikiAds should be relatively testable locally without a valid AdSense key, it's just that in debug mode the JS script from Google's servers isn't loaded and static <img> placeholder ads are served instead of dynamic JS and whatnot that is served in production).
The width cutoff is the same as for responsive MonoBook in MonoBook's skin.json so this should be decent-ish, provided Firefox's (and Chromium's) dev tools are any good.