Page MenuHomePhorge
Feed All Stories

Jul 20 2016

cook879 added a comment to T80: Create the skeleton of the extension.
Jul 20 2016, 8:37 PM · Unknown Object (Project)
cook879 added a comment to T80: Create the skeleton of the extension.

FYI, you can tag the task in the commit, or the commit in the task, so you don't have to add comments. Whatever way around you want to do it, it is done via the "Edit Related Objects" option in the menu on the right of the page.

Jul 20 2016, 8:37 PM · Unknown Object (Project)
CJC added a comment to T80: Create the skeleton of the extension.

See R20:2

Jul 20 2016, 4:45 PM · Unknown Object (Project)

Jul 18 2016

jack added a comment to T81: Get wiki data.

The EnhanceContactForm extension is about as simple as they come (although I should note that 1) the upstream version is slightly outdated again, the one in our repo includes an important HHVM patch, as ShoutWiki is using HHVM and thus we must address its quirks to avoid breaking the site, and 2) for whatever bizarre reasons that are beyond my comprehension upstream has managed to bloat a single-file extension into a bunch of irrelevant files and unnecessary (IMO) i18n).

Jul 18 2016, 3:09 PM · Unknown Object (Project)
jack added a comment to T86: Submission page.

What @cook879 is describing can be achieved with the jQuery UI dialog component (ResourceLoader module jquery.ui.dialog). Example use can be seen on Special:CreateWiki, step #3, when the chosen wiki type is "private" and you attempt to proceed to step 4 but both viewing and editing restrictions are set to "everyone" (in which case it obviously wouldn't be a private wiki!). The code for this can be found at /extensions/CreateWiki/scripts/createwiki.js, function checkForErrorsPage3. As always, ping me if you need help with this -- ResourceLoader is somewhat of a messy system even from the viewpoint of an experienced developer!

Jul 18 2016, 3:03 PM · Unknown Object (Project)
jack added a comment to T85: Page layout for user permissions.

IMO i18n isn't that huge of an issue, because 1) we're building the product to be i18n-able right from the start, as it should be and 2) we can always change the labels etc. either directly in the code or as an "afterthough" via the Interface Messages Wiki (mwmsg.sw).

Jul 18 2016, 2:59 PM · Unknown Object (Project)
lewiscawte renamed T81: Get wiki data from Get wikidata to Get wiki data.
Jul 18 2016, 7:49 AM · Unknown Object (Project)

Jul 17 2016

cook879 added a comment to T86: Submission page.

I was thinking maybe a, for lack of better word, "pop-up", telling them the request has been emailed and will be reviewed by staff as soon as possible. Then they click "ok" to close this message and are redirected back to Special:AdminPanel.

Jul 17 2016, 10:30 PM · Unknown Object (Project)
cook879 updated subscribers of T85: Page layout for user permissions.

I feel like we need a better name than user permissions. Maybe something along the lines of "privacy settings"? cc: @jack

Jul 17 2016, 10:28 PM · Unknown Object (Project)
cook879 added a comment to T84: Set up user permissions options.

To quote interns.shoutwiki:

Jul 17 2016, 10:27 PM · Unknown Object (Project)
cook879 updated subscribers of T81: Get wiki data.

Extension:EnhanceContactForm is how we currently do this in Special:Contact.

Jul 17 2016, 10:15 PM · Unknown Object (Project)
cook879 added a comment to T80: Create the skeleton of the extension.

My bad, commented on the wrong task

Jul 17 2016, 10:15 PM · Unknown Object (Project)
cook879 updated subscribers of T80: Create the skeleton of the extension.
Jul 17 2016, 10:14 PM · Unknown Object (Project)
CJC created T86: Submission page.
Jul 17 2016, 9:51 PM · Unknown Object (Project)
CJC created T85: Page layout for user permissions.
Jul 17 2016, 9:50 PM · Unknown Object (Project)
CJC created T84: Set up user permissions options.
Jul 17 2016, 9:49 PM · Unknown Object (Project)
CJC created T83: Get email working.
Jul 17 2016, 9:47 PM · Unknown Object (Project)
CJC created T82: Process data from form.
Jul 17 2016, 9:46 PM · Unknown Object (Project)
CJC created T81: Get wiki data.
Jul 17 2016, 9:45 PM · Unknown Object (Project)
CJC created T80: Create the skeleton of the extension.
Jul 17 2016, 9:45 PM · Unknown Object (Project)

Jul 15 2016

lewiscawte added a comment to T66: Enable MediaWiki login in Phabricator.

Which errors did you get?

Jul 15 2016, 10:57 PM · Phabricator
Southparkfan added a comment to T66: Enable MediaWiki login in Phabricator.

Which errors did you get?

Jul 15 2016, 8:00 PM · Phabricator

Jul 14 2016

jack created T77: High-definion logo support for certain ShoutWiki skins not utilizing Wiki.png/$wgLogo.
Jul 14 2016, 11:33 PM · Skins
lewiscawte changed the status of T76: Thumbnails not created for shared images from Invalid to Resolved.
Jul 14 2016, 1:56 PM · Restricted Project

Jul 13 2016

jack closed T51: Add wiki creation date (timestamp) into Special:MyWikis as Resolved.
Jul 13 2016, 2:54 PM · Sprint 22/06/16, CreateWiki
lewiscawte changed the status of T76: Thumbnails not created for shared images from Resolved to Invalid.
Jul 13 2016, 12:40 PM · Restricted Project
jack closed T76: Thumbnails not created for shared images as Resolved.

The [[https://www.mediawiki.org/wiki/Manual:$wgForeignFileRepos|$wgForeignFileRepos]] configuration setting for {de,es,fi}.shoutwiki.com had the wrong (old) value for the directory key (essentially due to T41: Cleanup legacy image pathing), which tells MW where the physical files are stored at. This is fixed now, but you may need to purge the page to see thumbnails again.

Jul 13 2016, 11:10 AM · Restricted Project

Jul 12 2016

isarra added a comment to T67: Redesign the Homepage.

You could also do fancy things with contentmodels.

Jul 12 2016, 11:13 PM · Restricted Project
--miki-- created T76: Thumbnails not created for shared images.
Jul 12 2016, 8:48 PM · Restricted Project

Jul 11 2016

lewiscawte closed T71: Scribunto not using SyntaxHighlight as Resolved.
Jul 11 2016, 5:25 PM
lewiscawte closed T71: Scribunto not using SyntaxHighlight, a subtask of T18: Deploy LuaSandbox to Monolith / Fix Scribunto, as Resolved.
Jul 11 2016, 5:24 PM · Sprint 22/06/16, Restricted Project
lewiscawte edited projects for T29: Fix DeleteWiki, added: DeleteWiki; removed CreateWiki.
Jul 11 2016, 5:03 PM · DeleteWiki, Restricted Project
lewiscawte edited projects for T26: Create a generic "ApiCreateWikiSuggestions" , added: DeleteWiki; removed CreateWiki.
Jul 11 2016, 5:03 PM · DeleteWiki, Technical Debt
lewiscawte edited projects for T59: Fix DeleteWiki log entries for wikis which do not have the language code in their subdomain, added: DeleteWiki; removed CreateWiki.
Jul 11 2016, 5:03 PM · DeleteWiki, I18n
lewiscawte created MyWikis.
Jul 11 2016, 4:59 PM
lewiscawte edited projects for T75: Add a common deletion reason dropdown, added: DeleteWiki; removed CreateWiki.
Jul 11 2016, 4:58 PM · DeleteWiki
lewiscawte created DeleteWiki.
Jul 11 2016, 4:57 PM
lewiscawte added a comment to T74: Provide a better No Such Wiki page.
In T74#941, @jack wrote:

Assuming most of our log entries are written to be "user safe", there should be nothing wrong with exposing the reason and date behind a wiki deletion (or multiple if that is the case).

They probably are (although I wouldn't want to go through all of them, or write a script to dump 'em either), but a lot of the time the reason isn't even interesting. A lot of them are like "request" or "ticket #so-and-so" or something like that -- obviously the deletion was requested since creators can't delete their wikis, and osTicket is a private communication channel between users and us; a user isn't able to view tickets created by others, so the fact that a wiki was deleted due to "osTicket #9803280" tells them absolutely nothing, I'm afraid.

Jul 11 2016, 3:46 PM · Design, Major Code, NoSuchWiki
lewiscawte created T75: Add a common deletion reason dropdown.
Jul 11 2016, 3:44 PM · DeleteWiki
jack added a comment to T74: Provide a better No Such Wiki page.

We should consider that the creator/admin isn't going to be the only one looking at a wiki.

This is obviously true, hence why Special:DeleteWiki is staff-only instead of something that'd allow admins/stewards to delete any wiki that they've created.

Jul 11 2016, 3:33 PM · Design, Major Code, NoSuchWiki
jack added a comment to T68: HAWelcome take into account SocialProfile.

I agree with the idea of merging both extensions. However, this isn't exactly a straightforward thing, because of the following:

  1. Usually users have the choice between a wiki user page and a social user profile, i.e. social profiles aren't enforced (SocialProfile's $wgUserPageChoice config var), so we need to take these into account...
  2. ...and even if social profiles were enforced, user boards and traditional user talk pages will coexist, because to my knowledge, it just isn't possible to get rid of user talk pages without significant core hacks. Generally speaking most users tend to prefer user boards over talk pages -- I guess it's easier to use those than to go to the desired user's talk page, click "edit", make changes, preview and finally save.
Jul 11 2016, 3:26 PM · Technical Debt
lewiscawte added a subtask for T74: Provide a better No Such Wiki page: T73: Always pass a requested wiki to NSW.
Jul 11 2016, 9:57 AM · Design, Major Code, NoSuchWiki
lewiscawte added a parent task for T73: Always pass a requested wiki to NSW: T74: Provide a better No Such Wiki page.
Jul 11 2016, 9:57 AM · NoSuchWiki
lewiscawte triaged T74: Provide a better No Such Wiki page as Normal priority.
Jul 11 2016, 9:57 AM · Design, Major Code, NoSuchWiki
lewiscawte created T74: Provide a better No Such Wiki page.
Jul 11 2016, 9:57 AM · Design, Major Code, NoSuchWiki
lewiscawte created T73: Always pass a requested wiki to NSW.
Jul 11 2016, 9:54 AM · NoSuchWiki
lewiscawte created NoSuchWiki.
Jul 11 2016, 9:16 AM
lewiscawte assigned T68: HAWelcome take into account SocialProfile to jack.

I'm in favour of either of these options - if we want to test the patch to HAWelcome and merge that it could be a great solution until a merge is completed.

Jul 11 2016, 9:03 AM · Technical Debt
lewiscawte triaged T42: Use Piwik API as Normal priority.
Jul 11 2016, 9:00 AM · CreateWiki
lewiscawte added a comment to T42: Use Piwik API.

The Piwik setup is in another country, with a different hosting provider, on a different network which makes it a lot slower to call - it used to be on rar which had private network access. Additionally, when MySQL throws an error (like connection), it takes a long time and has the entire CreateWiki request time out normally (unless something has been done to fix that), which results in broken wikis.

Jul 11 2016, 8:59 AM · CreateWiki
lewiscawte claimed T71: Scribunto not using SyntaxHighlight.
Jul 11 2016, 8:54 AM
lewiscawte added a parent task for T71: Scribunto not using SyntaxHighlight: T18: Deploy LuaSandbox to Monolith / Fix Scribunto.
Jul 11 2016, 8:54 AM
lewiscawte added a subtask for T18: Deploy LuaSandbox to Monolith / Fix Scribunto: T71: Scribunto not using SyntaxHighlight.
Jul 11 2016, 8:54 AM · Sprint 22/06/16, Restricted Project
lewiscawte added a comment to T71: Scribunto not using SyntaxHighlight.

Just be glad we got Scribunto working... you know how many insanely early mornings I put into fixing the blocking tasks to get T18 fixed?

Jul 11 2016, 8:54 AM

Jul 10 2016

jack closed T72: [Bug] Monaco UI Issues as Resolved.
Jul 10 2016, 11:44 PM · Monaco
jack claimed T72: [Bug] Monaco UI Issues.

I've prepared fixes & deployed 'em for both skins; our version of Nimbus is now in sync with upstream (see commit d095013c0b2a on phabricator.wikimedia.org).

Jul 10 2016, 9:26 PM · Monaco
mgagemorgan added a comment to T72: [Bug] Monaco UI Issues.

Does Nimbus also have a "MORE" menu like Monaco?

Jul 10 2016, 7:16 PM · Monaco
--miki-- added a comment to T72: [Bug] Monaco UI Issues.

In addition to Monaco, "More Wikis" is also broken in Nimbus.

Jul 10 2016, 6:47 PM · Monaco
mgagemorgan added a comment to T67: Redesign the Homepage.

Issarra: Do you just work on design? Is the extension idea out of scope and possibly under someone else? If so, I'd be happy to open a new report. However, these two need to work hand-in-hand: Extension and page.

Jul 10 2016, 5:59 PM · Restricted Project
mgagemorgan added a comment to T67: Redesign the Homepage.

And as for the issue with relevance, we may be able to "tag" wikis and get Piwik to figure out which wikis may seem relevant - kind of like advertising, but in a much sexier way: Instead of products, communities. Putting folks on the map.

Jul 10 2016, 5:54 PM · Restricted Project
mgagemorgan added a comment to T67: Redesign the Homepage.

CJC - I agree with your response to #2 - we want to show what the community is doing, and not even just the bigger ones; we probably should stand up for the little guys as well, as my attourney of an uncle would have said.

Jul 10 2016, 5:51 PM · Restricted Project
mgagemorgan added a comment to T67: Redesign the Homepage.

To add to my previous comment, JUST the wiki logo. That is the only image displayed. And, I'm curious about using Microsoft's "Modern" - I'd leave that to the community.

Jul 10 2016, 5:49 PM · Restricted Project
mgagemorgan added a comment to T67: Redesign the Homepage.

I like what Wikia does, but Lewis has a point: They likely were in the right mindset, but as we know with Wikia, there's a difference between theory and execution. I have a really simple idea for SW:

Jul 10 2016, 5:35 PM · Restricted Project
mgagemorgan created T72: [Bug] Monaco UI Issues.
Jul 10 2016, 5:23 PM · Monaco

Jul 9 2016

--miki-- created T71: Scribunto not using SyntaxHighlight.
Jul 9 2016, 8:56 PM
cook879 added a comment to T69: AdBlockDetector.

It would detect ad block users and put a nice little message asking them to consider unblocking us - nothing big or obtrusive or anything. But it hasn't really been thought about much besides a small, untested prototype I wrote a while ago.

Jul 9 2016, 6:31 PM · Advertising
Bouncepaw added a comment to T69: AdBlockDetector.

What does it do?

Jul 9 2016, 6:23 PM · Advertising
cook879 created T70: Benchmark FilterListUsers SQL query.
Jul 9 2016, 4:49 PM · Other/Unspecified
cook879 updated the task description for T69: AdBlockDetector.
Jul 9 2016, 4:45 PM · Advertising
cook879 created T69: AdBlockDetector.
Jul 9 2016, 4:44 PM · Advertising
cook879 created T68: HAWelcome take into account SocialProfile.
Jul 9 2016, 4:36 PM · Technical Debt
Bouncepaw added a comment to T67: Redesign the Homepage.
  1. Sidebar would be great.
Jul 9 2016, 7:26 AM · Restricted Project

Jul 8 2016

CJC added a comment to T67: Redesign the Homepage.
  1. Literally just listing them provides no incentive to go to them. That is where at least a logo might make it more eyecatching. Maybe displaying a bit from an article? Not sure how that would work though.
Jul 8 2016, 6:27 PM · Unknown Object (Project)

Jul 6 2016

Bouncepaw added a comment to T67: Redesign the Homepage.
  1. What about this tiles like in Windows 8 & 10?
  2. I know only one way to get to Phabricator: write URL in the address bar. Link can make it easier.
Jul 6 2016, 3:38 PM · Unknown Object (Project)
lewiscawte added a comment to T67: Redesign the Homepage.

2 - We should certainly be promoting some of our wikis on the home page - how we're going to do that I don't think has been decided yet. I'm not a big fan of just listing them, though.

Jul 6 2016, 9:26 AM · Unknown Object (Project)
Bouncepaw added a comment to T67: Redesign the Homepage.

I'm not a designer at all, but I have some ideas:

  1. Use flat design;
  2. List popular and big wiki;
  3. Make giant blue button that creates a wiki;
  4. Little amount of text, more pictures;
  5. What is the logo of Shoutwiki? Butterfly? Maybe change it?
  6. How much languages are supported? 10? It's not very much, don't you think so? If I remember correctly, Wikia supports more languages;
  7. More help pages;
  8. Make giant blue button that user can contact support Team with;
  9. Link to Phabricator somewhere;
  10. Make giant blue button that links to forum.

What do you think?

Jul 6 2016, 8:05 AM · Unknown Object (Project)
isarra added a comment to T67: Redesign the Homepage.

For reference, even if some of it might be a bit redundant:

Jul 6 2016, 12:46 AM · Unknown Object (Project)

Jul 5 2016

lewiscawte added a comment to T67: Redesign the Homepage.

So I'm no authority on design, but here are my thoughts and an idea or two.

Jul 5 2016, 7:40 PM · Unknown Object (Project)
lewiscawte created T67: Redesign the Homepage.
Jul 5 2016, 7:22 PM · Unknown Object (Project)
lewiscawte added a comment to T66: Enable MediaWiki login in Phabricator.

The Wikimedia code for this is available in their phabricator/extensions repository.

Jul 5 2016, 6:09 PM · Phabricator
lewiscawte created T66: Enable MediaWiki login in Phabricator.
Jul 5 2016, 6:05 PM · Phabricator

Jul 3 2016

lewiscawte closed T45: Missing texvccheck executable as Resolved.

Compiled 2/7/16.

Jul 3 2016, 7:56 PM · Math, Sprint 22/06/16, Restricted Project
lewiscawte added a watcher for Interns: lewiscawte.
Jul 3 2016, 7:53 PM
cook879 created T65: Decide on what settings and extensions are eligible for inclusion.
Jul 3 2016, 12:33 PM · Unknown Object (Project)
cook879 added a member for Interns: CJC.
Jul 3 2016, 12:10 PM
cook879 added a member for Interns: ddixit.
Jul 3 2016, 12:10 PM
jack added a comment to T63: Handle most errors.

"Hundreds of lines of error handling code" is hopefully somewhat of an overstatement. ;-) T64 and the like can be worked around with a try-catch loop, for example. Right now in CreateWikiBackend::initDB(), line 479, we blindly source the files listed in $wgCreateWikiSQLFiles (regardless of their existence or the lack of thereof!) against the newly created DB with DatabaseBase::sourceFile(), which seems to throw a MWException if it can't open the file. So maybe something like this would work:

Jul 3 2016, 10:45 AM · CreateWiki
lewiscawte closed T64: CreateWiki loads a non-existent SQL file causing fatals as Resolved.
Jul 3 2016, 7:23 AM · CreateWiki
lewiscawte closed T64: CreateWiki loads a non-existent SQL file causing fatals, a subtask of T63: Handle most errors, as Resolved.
Jul 3 2016, 7:23 AM · CreateWiki
lewiscawte added a subtask for T63: Handle most errors: T64: CreateWiki loads a non-existent SQL file causing fatals.
Jul 3 2016, 7:17 AM · CreateWiki
lewiscawte added a parent task for T64: CreateWiki loads a non-existent SQL file causing fatals: T63: Handle most errors.
Jul 3 2016, 7:17 AM · CreateWiki
lewiscawte created T64: CreateWiki loads a non-existent SQL file causing fatals.
Jul 3 2016, 7:17 AM · CreateWiki
lewiscawte created T63: Handle most errors.
Jul 3 2016, 7:13 AM · CreateWiki

Jul 2 2016

jack created T62: Consolidate the Games and Sports skins.
Jul 2 2016, 1:40 AM · Technical Debt, Skins
jack created T61: Remove inline CSS from the Games skin.
Jul 2 2016, 12:53 AM · Technical Debt, Skins
jack closed T60: Fix no logo Nimbus bug as Resolved.

Upstream patch: https://gerrit.wikimedia.org/r/#/c/297114/
Local patch: {rSHWK3895}

Jul 2 2016, 12:44 AM · Skins

Jul 1 2016

jack added a comment to T60: Fix no logo Nimbus bug.
#site-logo {
	min-height: 150px;
}

fixes this bug. I'll try to commit a patch later today...

Jul 1 2016, 9:45 AM · Skins

Jun 28 2016

cook879 added a comment to T60: Fix no logo Nimbus bug.

I feel like the ideal solution to this is to deal with it via CSS, even if we just do something where we detect no image we put a blank clear one in there. We can put in as many defaults as we like, but at the end of the day that doesn't stop users deleting the images and having the bug.

Jun 28 2016, 9:44 PM · Skins

Jun 24 2016

jack added a project to T60: Fix no logo Nimbus bug: Skins.

Perhaps we should implement a default logo of some kind in the Nimbus skin itself? Right now it uses $wgLogo (i.e. Wiki.png on ShoutWiki), but some skins (such as Quartz) use that skin's custom logo (Wiki_wide.png in Quartz) and fall back to $wgLogo if there's no appropriate, skin-specific custom logo...which actually doesn't handle the "$wgLogo doesn't exist" case at all. Maybe I'm wrong and this indeed is a real code bug that we could and should handle with CSS or something. Thoughts?

Jun 24 2016, 7:48 AM · Skins

Jun 23 2016

cook879 added a comment to T60: Fix no logo Nimbus bug.

While importing from starter should avoid this problem, the imported image did not appear. This may be related to our recent changes to image paths and may or may not still be a problem - I know there were changes recently to fix some legacy paths in CreateWiki

Jun 23 2016, 8:33 PM · Skins