Page MenuHomePhorge
Feed All Stories

Jul 11 2016

lewiscawte claimed T71: Scribunto not using SyntaxHighlight.
Jul 11 2016, 8:54 AM
lewiscawte added a parent task for T71: Scribunto not using SyntaxHighlight: T18: Deploy LuaSandbox to Monolith / Fix Scribunto.
Jul 11 2016, 8:54 AM
lewiscawte added a subtask for T18: Deploy LuaSandbox to Monolith / Fix Scribunto: T71: Scribunto not using SyntaxHighlight.
Jul 11 2016, 8:54 AM · Sprint 22/06/16, Restricted Project
lewiscawte added a comment to T71: Scribunto not using SyntaxHighlight.

Just be glad we got Scribunto working... you know how many insanely early mornings I put into fixing the blocking tasks to get T18 fixed?

Jul 11 2016, 8:54 AM

Jul 10 2016

jack closed T72: [Bug] Monaco UI Issues as Resolved.
Jul 10 2016, 11:44 PM · Monaco
jack claimed T72: [Bug] Monaco UI Issues.

I've prepared fixes & deployed 'em for both skins; our version of Nimbus is now in sync with upstream (see commit d095013c0b2a on phabricator.wikimedia.org).

Jul 10 2016, 9:26 PM · Monaco
mgagemorgan added a comment to T72: [Bug] Monaco UI Issues.

Does Nimbus also have a "MORE" menu like Monaco?

Jul 10 2016, 7:16 PM · Monaco
--miki-- added a comment to T72: [Bug] Monaco UI Issues.

In addition to Monaco, "More Wikis" is also broken in Nimbus.

Jul 10 2016, 6:47 PM · Monaco
mgagemorgan added a comment to T67: Redesign the Homepage.

Issarra: Do you just work on design? Is the extension idea out of scope and possibly under someone else? If so, I'd be happy to open a new report. However, these two need to work hand-in-hand: Extension and page.

Jul 10 2016, 5:59 PM · Unknown Object (Project)
mgagemorgan added a comment to T67: Redesign the Homepage.

And as for the issue with relevance, we may be able to "tag" wikis and get Piwik to figure out which wikis may seem relevant - kind of like advertising, but in a much sexier way: Instead of products, communities. Putting folks on the map.

Jul 10 2016, 5:54 PM · Unknown Object (Project)
mgagemorgan added a comment to T67: Redesign the Homepage.

CJC - I agree with your response to #2 - we want to show what the community is doing, and not even just the bigger ones; we probably should stand up for the little guys as well, as my attourney of an uncle would have said.

Jul 10 2016, 5:51 PM · Unknown Object (Project)
mgagemorgan added a comment to T67: Redesign the Homepage.

To add to my previous comment, JUST the wiki logo. That is the only image displayed. And, I'm curious about using Microsoft's "Modern" - I'd leave that to the community.

Jul 10 2016, 5:49 PM · Unknown Object (Project)
mgagemorgan added a comment to T67: Redesign the Homepage.

I like what Wikia does, but Lewis has a point: They likely were in the right mindset, but as we know with Wikia, there's a difference between theory and execution. I have a really simple idea for SW:

Jul 10 2016, 5:35 PM · Unknown Object (Project)
mgagemorgan created T72: [Bug] Monaco UI Issues.
Jul 10 2016, 5:23 PM · Monaco

Jul 9 2016

--miki-- created T71: Scribunto not using SyntaxHighlight.
Jul 9 2016, 8:56 PM
cook879 added a comment to T69: AdBlockDetector.

It would detect ad block users and put a nice little message asking them to consider unblocking us - nothing big or obtrusive or anything. But it hasn't really been thought about much besides a small, untested prototype I wrote a while ago.

Jul 9 2016, 6:31 PM · Advertising
Bouncepaw added a comment to T69: AdBlockDetector.

What does it do?

Jul 9 2016, 6:23 PM · Advertising
cook879 created T70: Benchmark FilterListUsers SQL query.
Jul 9 2016, 4:49 PM · Other/Unspecified
cook879 updated the task description for T69: AdBlockDetector.
Jul 9 2016, 4:45 PM · Advertising
cook879 created T69: AdBlockDetector.
Jul 9 2016, 4:44 PM · Advertising
cook879 created T68: HAWelcome take into account SocialProfile.
Jul 9 2016, 4:36 PM · Technical Debt
Bouncepaw added a comment to T67: Redesign the Homepage.
  1. Sidebar would be great.
Jul 9 2016, 7:26 AM · Unknown Object (Project)

Jul 8 2016

CJC added a comment to T67: Redesign the Homepage.
  1. Literally just listing them provides no incentive to go to them. That is where at least a logo might make it more eyecatching. Maybe displaying a bit from an article? Not sure how that would work though.
Jul 8 2016, 6:27 PM · Unknown Object (Project)

Jul 6 2016

Bouncepaw added a comment to T67: Redesign the Homepage.
  1. What about this tiles like in Windows 8 & 10?
  2. I know only one way to get to Phabricator: write URL in the address bar. Link can make it easier.
Jul 6 2016, 3:38 PM · Unknown Object (Project)
lewiscawte added a comment to T67: Redesign the Homepage.

2 - We should certainly be promoting some of our wikis on the home page - how we're going to do that I don't think has been decided yet. I'm not a big fan of just listing them, though.

Jul 6 2016, 9:26 AM · Unknown Object (Project)
Bouncepaw added a comment to T67: Redesign the Homepage.

I'm not a designer at all, but I have some ideas:

  1. Use flat design;
  2. List popular and big wiki;
  3. Make giant blue button that creates a wiki;
  4. Little amount of text, more pictures;
  5. What is the logo of Shoutwiki? Butterfly? Maybe change it?
  6. How much languages are supported? 10? It's not very much, don't you think so? If I remember correctly, Wikia supports more languages;
  7. More help pages;
  8. Make giant blue button that user can contact support Team with;
  9. Link to Phabricator somewhere;
  10. Make giant blue button that links to forum.

What do you think?

Jul 6 2016, 8:05 AM · Unknown Object (Project)
isarra added a comment to T67: Redesign the Homepage.

For reference, even if some of it might be a bit redundant:

Jul 6 2016, 12:46 AM · Unknown Object (Project)

Jul 5 2016

lewiscawte added a comment to T67: Redesign the Homepage.

So I'm no authority on design, but here are my thoughts and an idea or two.

Jul 5 2016, 7:40 PM · Unknown Object (Project)
lewiscawte created T67: Redesign the Homepage.
Jul 5 2016, 7:22 PM · Unknown Object (Project)
lewiscawte added a comment to T66: Enable MediaWiki login in Phabricator.

The Wikimedia code for this is available in their phabricator/extensions repository.

Jul 5 2016, 6:09 PM · Phabricator
lewiscawte created T66: Enable MediaWiki login in Phabricator.
Jul 5 2016, 6:05 PM · Phabricator

Jul 3 2016

lewiscawte closed T45: Missing texvccheck executable as Resolved.

Compiled 2/7/16.

Jul 3 2016, 7:56 PM · Math, Sprint 22/06/16, Restricted Project
lewiscawte added a watcher for Interns: lewiscawte.
Jul 3 2016, 7:53 PM
cook879 created T65: Decide on what settings and extensions are eligible for inclusion.
Jul 3 2016, 12:33 PM · Unknown Object (Project)
cook879 added a member for Interns: CJC.
Jul 3 2016, 12:10 PM
cook879 added a member for Interns: ddixit.
Jul 3 2016, 12:10 PM
jack added a comment to T63: Handle most errors.

"Hundreds of lines of error handling code" is hopefully somewhat of an overstatement. ;-) T64 and the like can be worked around with a try-catch loop, for example. Right now in CreateWikiBackend::initDB(), line 479, we blindly source the files listed in $wgCreateWikiSQLFiles (regardless of their existence or the lack of thereof!) against the newly created DB with DatabaseBase::sourceFile(), which seems to throw a MWException if it can't open the file. So maybe something like this would work:

Jul 3 2016, 10:45 AM · CreateWiki
lewiscawte closed T64: CreateWiki loads a non-existent SQL file causing fatals as Resolved.
Jul 3 2016, 7:23 AM · CreateWiki
lewiscawte closed T64: CreateWiki loads a non-existent SQL file causing fatals, a subtask of T63: Handle most errors, as Resolved.
Jul 3 2016, 7:23 AM · CreateWiki
lewiscawte added a subtask for T63: Handle most errors: T64: CreateWiki loads a non-existent SQL file causing fatals.
Jul 3 2016, 7:17 AM · CreateWiki
lewiscawte added a parent task for T64: CreateWiki loads a non-existent SQL file causing fatals: T63: Handle most errors.
Jul 3 2016, 7:17 AM · CreateWiki
lewiscawte created T64: CreateWiki loads a non-existent SQL file causing fatals.
Jul 3 2016, 7:17 AM · CreateWiki
lewiscawte created T63: Handle most errors.
Jul 3 2016, 7:13 AM · CreateWiki

Jul 2 2016

jack created T62: Consolidate the Games and Sports skins.
Jul 2 2016, 1:40 AM · Technical Debt, Skins
jack created T61: Remove inline CSS from the Games skin.
Jul 2 2016, 12:53 AM · Technical Debt, Skins
jack closed T60: Fix no logo Nimbus bug as Resolved.

Upstream patch: https://gerrit.wikimedia.org/r/#/c/297114/
Local patch: {rSHWK3895}

Jul 2 2016, 12:44 AM · Skins

Jul 1 2016

jack added a comment to T60: Fix no logo Nimbus bug.
#site-logo {
	min-height: 150px;
}

fixes this bug. I'll try to commit a patch later today...

Jul 1 2016, 9:45 AM · Skins

Jun 28 2016

cook879 added a comment to T60: Fix no logo Nimbus bug.

I feel like the ideal solution to this is to deal with it via CSS, even if we just do something where we detect no image we put a blank clear one in there. We can put in as many defaults as we like, but at the end of the day that doesn't stop users deleting the images and having the bug.

Jun 28 2016, 9:44 PM · Skins

Jun 24 2016

jack added a project to T60: Fix no logo Nimbus bug: Skins.

Perhaps we should implement a default logo of some kind in the Nimbus skin itself? Right now it uses $wgLogo (i.e. Wiki.png on ShoutWiki), but some skins (such as Quartz) use that skin's custom logo (Wiki_wide.png in Quartz) and fall back to $wgLogo if there's no appropriate, skin-specific custom logo...which actually doesn't handle the "$wgLogo doesn't exist" case at all. Maybe I'm wrong and this indeed is a real code bug that we could and should handle with CSS or something. Thoughts?

Jun 24 2016, 7:48 AM · Skins

Jun 23 2016

cook879 added a comment to T60: Fix no logo Nimbus bug.

While importing from starter should avoid this problem, the imported image did not appear. This may be related to our recent changes to image paths and may or may not still be a problem - I know there were changes recently to fix some legacy paths in CreateWiki

Jun 23 2016, 8:33 PM · Skins
cook879 created T60: Fix no logo Nimbus bug.
Jun 23 2016, 8:29 PM · Skins

Jun 22 2016

lewiscawte closed T50: Run /maintenance/initSiteStats.php globally as Resolved.
Jun 22 2016, 11:17 PM · Restricted Project
lewiscawte added a comment to T51: Add wiki creation date (timestamp) into Special:MyWikis.

So I've implemented this functionality to CreateWiki, it uses wl_timestamp from wiki_list as it's timestamp. The code could probably be cleaned up a little further, but it works for now.

Jun 22 2016, 10:28 PM · Sprint 22/06/16, CreateWiki
isarra added a comment to T55: Rewrite CreateWiki Frontend.

I forgot what page three is, but remove any redundancies, clarify any unclear bits, group related bits, etc. Basically like the page 1 changes.

Jun 22 2016, 8:37 PM · Technical Debt, Design, Major Code, CreateWiki
isarra added a comment to T55: Rewrite CreateWiki Frontend.

For page two, make it out like sections for each skin, with a big checkbox by the title of each. Technically the entire thing is a table, as such:

Jun 22 2016, 8:34 PM · Technical Debt, Design, Major Code, CreateWiki
isarra added a comment to T55: Rewrite CreateWiki Frontend.

Also note that the form styles like the buttons and stuff should actually be provided by the skin or mw-ui/oojs; unfortunately none of the skins actually do, and stuff. But the padding would be standard form padding; the blue button would be standard progressive, etc.

Jun 22 2016, 8:25 PM · Technical Debt, Design, Major Code, CreateWiki
isarra added a comment to T55: Rewrite CreateWiki Frontend.

Mockup for the first page:

createwiki page 1 mockup (757×887 px, 69 KB)

Jun 22 2016, 8:22 PM · Technical Debt, Design, Major Code, CreateWiki
lewiscawte closed T18: Deploy LuaSandbox to Monolith / Fix Scribunto as Resolved.

LuaSandbox is now deployed on Monolith, and namespaceDupes.php is running to move all the Module: namespace pages to the correct namespace.

Jun 22 2016, 7:17 PM · Sprint 22/06/16, Restricted Project
lewiscawte moved T59: Fix DeleteWiki log entries for wikis which do not have the language code in their subdomain from Backlog to Stretch Goals on the Sprint 22/06/16 board.
Jun 22 2016, 6:52 AM · DeleteWiki, I18n
lewiscawte added a project to T59: Fix DeleteWiki log entries for wikis which do not have the language code in their subdomain: Sprint 22/06/16.
Jun 22 2016, 6:51 AM · DeleteWiki, I18n
jack created T59: Fix DeleteWiki log entries for wikis which do not have the language code in their subdomain.
Jun 22 2016, 6:50 AM · DeleteWiki, I18n

Jun 21 2016

lewiscawte created T58: Review effectiveness of ads.
Jun 21 2016, 11:04 PM · Advertising
lewiscawte created T57: Reporting Ads.
Jun 21 2016, 10:34 PM · Advertising
jack added a comment to T55: Rewrite CreateWiki Frontend.

the wiki 'type' value we ask users to set has no impact on these settings and sometimes does not reflect the permissions at all

Actually it does, kinda. On step 3, "Editing restrictions" and "Viewing restrictions" drop-down menus don't appear unless the wiki type is either private or school (although they, for whatever reason, did appear to me once even when wiki type was set to public. JS is weird.).
Furthermore if the chosen wiki type is "school", then the additional option "Users with an email address from" appears in both of the aforementioned drop-down menus. This causes a configuration variable, either $wgViewValidEmail or $wgEditValidEmail to be written to the generated Settings.php file. And as you noted, these two variables do nothing even though they probably should. We should probably look into integrating the PrivateDomains extension here somehow, since AFAIK the underlying idea was always to use PrivateDomains for these not-so-public wikis.

Jun 21 2016, 10:32 PM · Technical Debt, Design, Major Code, CreateWiki
lewiscawte updated subscribers of T55: Rewrite CreateWiki Frontend.
Jun 21 2016, 10:28 PM · Technical Debt, Design, Major Code, CreateWiki
lewiscawte added a comment to T55: Rewrite CreateWiki Frontend.

In addition to this, the wiki 'type' value we ask users to set has no impact on these settings and sometimes does not reflect the permissions at all.

Jun 21 2016, 10:27 PM · Technical Debt, Design, Major Code, CreateWiki
jack created T56: Convert CreateWiki to extension registration system (extension.json).
Jun 21 2016, 10:23 PM · Technical Debt, CreateWiki
lewiscawte created T55: Rewrite CreateWiki Frontend.
Jun 21 2016, 10:21 PM · Technical Debt, Design, Major Code, CreateWiki
lewiscawte moved T51: Add wiki creation date (timestamp) into Special:MyWikis from Backlog to Stretch Goals on the Sprint 22/06/16 board.
Jun 21 2016, 10:07 PM · Sprint 22/06/16, CreateWiki
lewiscawte moved T45: Missing texvccheck executable from Backlog to Stretch Goals on the Sprint 22/06/16 board.
Jun 21 2016, 10:07 PM · Math, Sprint 22/06/16, Restricted Project
lewiscawte moved T18: Deploy LuaSandbox to Monolith / Fix Scribunto from Backlog to Confirmed Tasks on the Sprint 22/06/16 board.
Jun 21 2016, 10:07 PM · Sprint 22/06/16, Restricted Project
lewiscawte added a project to T18: Deploy LuaSandbox to Monolith / Fix Scribunto: Sprint 22/06/16.
Jun 21 2016, 10:04 PM · Sprint 22/06/16, Restricted Project
lewiscawte added a project to T45: Missing texvccheck executable: Sprint 22/06/16.
Jun 21 2016, 10:04 PM · Math, Sprint 22/06/16, Restricted Project
lewiscawte added a project to T51: Add wiki creation date (timestamp) into Special:MyWikis: Sprint 22/06/16.
Jun 21 2016, 10:04 PM · Sprint 22/06/16, CreateWiki
lewiscawte added a hashtag to Sprint 22/06/16: #sprint-22-06-16.
Jun 21 2016, 10:00 PM
lewiscawte created Sprint 22/06/16.
Jun 21 2016, 10:00 PM
jack closed T29: Fix DeleteWiki as Resolved.

{rSHWK3884}, which I deployed earlier on, fixed this. (At least I believe it was that revision, might also have something to do with the few older patches, of which at least one was related to analytics. Anyway RESOLVED FIXED.)

Jun 21 2016, 9:57 PM · DeleteWiki, Restricted Project
lewiscawte closed T20: Google marking our emails as spam as Resolved.
Jun 21 2016, 8:50 PM · Restricted Project
lewiscawte added a comment to T50: Run /maintenance/initSiteStats.php globally.

Currently running, position (alphabetically as of posting): brandyland.

Jun 21 2016, 4:05 PM · Restricted Project

Jun 17 2016

cook879 created Interns.
Jun 17 2016, 8:21 PM

Jun 16 2016

lewiscawte changed the visibility for T25: Upgrade from 12.04.
Jun 16 2016, 11:16 PM · Restricted Project
lewiscawte closed T25: Upgrade from 12.04 as Resolved.

Grunt and Vertex were upgraded this morning.

Jun 16 2016, 11:16 PM · Restricted Project
lewiscawte closed T25: Upgrade from 12.04, a subtask of T18: Deploy LuaSandbox to Monolith / Fix Scribunto, as Resolved.
Jun 16 2016, 11:16 PM · Sprint 22/06/16, Restricted Project
SamanthaNguyen added a comment to T53: Investigate Metrolook ad placement.

There's a document.write in https://phabricator.wikimedia.org/diffusion/EDSN/browse/master/DismissableSiteNotice.hooks.php , what do you think?

Jun 16 2016, 10:12 PM · Advertising, Skins
SamanthaNguyen added a member for Mobile: SamanthaNguyen.
Jun 16 2016, 10:05 PM
jack added a comment to T53: Investigate Metrolook ad placement.

So something somewhere is calling document.write, which isn't really supported in MediaWiki anymore and that's breaking things. This results in a warning logged into the browser's JS console: "Use of 'write' is deprecated. Use jQuery or mw.loader.load instead.". This traces back to the file /resources/src/mediawiki.legacy/wikibits.js.
I was able to reproduce the broken ad behavior in Opera 37.0.2178.32 under Windows 7.

Jun 16 2016, 4:51 PM · Advertising, Skins
jack added a comment to T54: User menu is overlayed by ShoutWikiAds sidebar advertisement .
div#mw-panel-right {
	top: 120px;
}

might/should fix this, at least for anons. Tested on Opera 37.0.2178.32 under Windows 7. No idea what to do w/ logged-in users, though.

Jun 16 2016, 4:45 PM · Advertising, Skins
lewiscawte added a comment to T54: User menu is overlayed by ShoutWikiAds sidebar advertisement .

The ad needs pushing further down the page. Overlaying that user menu on top of the ad is just calling for an invalid click activity strike.

Jun 16 2016, 5:53 AM · Advertising, Skins

Jun 15 2016

MtMNC added a comment to T53: Investigate Metrolook ad placement.

Oddly enough, I've gotten several different ad placements, including the correct one. This is on Chrome 51.0.2704.84 on OS X 10.11.4 (El Capitan). Here are some examples:

Jun 15 2016, 9:08 PM · Advertising, Skins
SamanthaNguyen created T54: User menu is overlayed by ShoutWikiAds sidebar advertisement .
Jun 15 2016, 8:30 PM · Advertising, Skins
SamanthaNguyen added a comment to T53: Investigate Metrolook ad placement.

Sidebar isn't working, after a couple of refreshes here and there - Using Windows 10, Chrome v51.0.2704.84, 1366 x 768

Jun 15 2016, 8:25 PM · Advertising, Skins
jack changed the visibility for Mobile.
Jun 15 2016, 8:03 PM
jack changed the visibility for I18n.
Jun 15 2016, 8:03 PM
jack changed the visibility for Monaco.
Jun 15 2016, 8:02 PM
jack changed the visibility for Aurora.
Jun 15 2016, 8:02 PM
jack changed the visibility for Other/Unspecified.
Jun 15 2016, 8:01 PM
jack changed the visibility for SharedNewtalk.
Jun 15 2016, 8:01 PM
jack changed the visibility for ProblemReports.
Jun 15 2016, 8:01 PM
jack changed the visibility for CreateWiki.
Jun 15 2016, 8:00 PM
jack changed the visibility for Skins.
Jun 15 2016, 8:00 PM